- 🇬🇧United Kingdom steven jones
Confirmed, this is broken with batched exports. This is a prime candidate for adding some tests.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
We have failing tests, and still need new tests. The MR also introduces PHPCS issues.
since version 8.x-1.0-beta3, some of the view tokens ( [view:total-rows] , [view:current-page] and [view:page-count] ) are not correctly replaced in the filename for the download file.
even though the token replacement is done at a later stage in the flow in version 8.x-1.0-beta3, in static method \Drupal\views_data_export\Plugin\views\display\DataExport::buildResponse , the values needed for the token replacement are not available, as the previously executed view is not available here, yet a new view object view is generated ad-hoc inside this static method.
not sure how i would fix this, and i don't have the time to dig deep into this at the moment :(
Active
1.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Confirmed, this is broken with batched exports. This is a prime candidate for adding some tests.
We have failing tests, and still need new tests. The MR also introduces PHPCS issues.