- 🇬🇧United Kingdom aaron.ferris
Initial code change for this is in the MR, flat paths at the moment - need to add an option for any 'Path starts with'.
Also had some issues with fatals in this module, namely:
Error: Class "Url" not found in maintenance_mode_redirect_help() (line 17 of /var/www/html/web/modules/contrib/maintenance_mode_redirect-3086569/maintenance_mode_redirect.module).
TypeError: Drupal\maintenance_mode_redirect\EventSubscriber\MaintenanceModeRedirectSubscriber::checkForRedirection(): Argument #1 ($event) must be of type Drupal\maintenance_mode_redirect\EventSubscriber\GetResponseEvent, Symfony\Component\HttpKernel\Event\RequestEvent given in Drupal\maintenance_mode_redirect\EventSubscriber\MaintenanceModeRedirectSubscriber->checkForRedirection() (line 32 of /var/www/html/web/modules/contrib/maintenance_mode_redirect-3086569/src/EventSubscriber/MaintenanceModeRedirectSubscriber.php).
Both should be fixed in the attached MR.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 12:25pm 8 June 2024 - Status changed to RTBC
6 months ago 1:40pm 8 June 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
I reviewed the code and I didn't find anything wrong.
I noticed that the configuration values have names that are prefixed by the module name, but that should be fixed in a different issue. - 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 2.x to hidden.
-
apaderno →
committed e1995ba8 on 2.x authored by
aaron.ferris →
Issue #3086569: Add ability to add user-specified paths to not redirect
-
apaderno →
committed e1995ba8 on 2.x authored by
aaron.ferris →
- Status changed to Fixed
6 months ago 8:32am 9 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.