Content Translation support

anup.singh → made their first commit to this issue’s fork.

I tried to merge but the pipeline failed

Thanks for trying @adriancid (and thanks for all your work getting the other issues in these last days!). This one is ready again, no more phpcs failure. Phpstan failures are unrelated and exist on 3.x branch as well so we can leave those to 📌 Phpstan + Cspell + Drupal 11 compatibility fixes RTBC to prep for D11.

Wow! Code looks good, and works in limited testing.

I can also confirm that this works great; I managed to see the Translation overview and get to the translation form! Thank you! BUT when on the actual translation form, an error is now showing:

Drupal\form_mode_manager_theme_switcher\Theme\FormModeThemeNegociator->isApplicable() (line 93 of modules/contrib/form_mode_manager/modules/form_mode_theme_switcher/src/Theme/FormModeThemeNegociator.php).

We need a check on $route->getDefault('_entity_form') inside the str_replace in case the route default is not set (for example, when adding a translation) and $route->getDefault('_entity_form') returns NULL which causes the deprecation error above.

Just pushed a commit to the MR containing a check that fixes the deprecated error.

Full error (sorry missed the first important bit of it on my previous comment):

Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\form_mode_manager_theme_switcher\Theme\FormModeThemeNegociator->isApplicable() (line 93 of modules/contrib/form_mode_manager/modules/form_mode_theme_switcher/src/Theme/FormModeThemeNegociator.php).

-> fixed phpcs errors

Changed back to targetting 8.x-2.x-dev as the tests failed (when using 3.x.dev they were ruining on D11, and the module is not compatible)

some one with access should re-trigger the test manually

scott_euser → changed the visibility of the branch 3.x to hidden.

Thanks! Shall I sort out the phpstan issues or you working on that?

If you can fix them will be great, can you take a quick look? As I want to release a new version.

Sure give me a couple hours, will do once I get my daughter to sleep

Too muddled up being target 3x merge, starting new issue here to sort 📌 Fix phpstan errors Active . Marking fixed, but unable to do credits myself, so will leave that to you to go through contributors. Will update follow-up shortly with MR

The MR https://git.drupalcode.org/project/form_mode_manager/-/merge_requests/15 is empty

scott_euser → changed the visibility of the branch 3080322-phpstan-fixes to hidden.

Yeah working on it here: https://www.drupal.org/project/form_mode_manager/issues/3490537 📌 Fix phpstan errors Active as noted above.

I think maybe this issue is the reason; but its not a quick change so moved to a follow-up. Probably this issue was original targeting an old branch and the merge request was changed target without retest resulting in a bunch of issues. Just re-running the test suite over there, but should be MR ready soon.

Okay these are both ready for you:

1. 📌 Fix phpstan errors Active - Fixes the phpstan errors
2. 📌 Improve configuration page UX Active - Minor UX nitpicks in the configuration form

Thanks very much!

Automatically closed - issue fixed for 2 weeks with no activity.