Clearfix on wrapper could lead to unwanted sideeffects.

Created on 3 September 2019, almost 5 years ago
Updated 23 June 2023, about 1 year ago

Problem/Motivation

The views_infinite_scroll module adds a wrapper around the views content to perform its AJAX commands.

<div data-drupal-views-infinite-scroll-content-wrapper="" class="views-infinite-scroll-content-wrapper clearfix">

The clearfix could lead to undesired side-effects when your views rows are not floated, but e.g. use flexbox for their arrangement.

Proposed resolution

In my opinion should the module not be biased on any frontend implementation and therefore not add a clearfix.
Unfortunately this could be a breaking change, if sites are implicitly relying on the existing clearfix.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Postponed: needs info

Version

1.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany szeidler Berlin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Is this still an issue with 2.0.x? If yes, please update the version and set the status active again with clear steps or (best) with a test showing what's broken.

    2.0.x is the active development branch.

    If nobody replies, we should assume this is fixed and close this issue outdated.

    Thanks!

Production build 0.69.0 2024