Contrib.social

Refactor drush commands into base module

Open on Drupal.org →
Created on 31 August 2019, over 5 years ago
Updated 18 October 2023, over 1 year ago

After installing and enabling purge using: drush en purge purge_ui purge_drush purge_queuer_coretags purge_processor_cron

Sanity check result: [notice] Already enabled: purge, purge_ui, purge_drush, purge_queuer_coretags, purge_processor_cron

Drush commands for purge do not work. All drush commands for the purge state 'alias not defined'.

Example:

alec@workroom-svr:~/d8$ drush pqe
         Command "pqe" is not defined.

Command using --debug

Drush Launcher Version: 0.6.0
ROOT: /home/alec/d8
DRUSH VERSION: 9
DRUPAL ROOT: /home/alec/d8/web
COMPOSER ROOT: /home/alec/d8
VENDOR ROOT: /home/alec/d8/vendor
 [preflight] Config paths: /home/alec/d8/vendor/drush/drush/drush.yml,/home/alec/d8/drush/drush.yml
 [preflight] Alias paths: /home/alec/d8/web/drush/sites,/home/alec/d8/drush/sites
 [preflight] Commandfile search paths: /home/alec/d8/vendor/drush/drush/src,/home/alec/d8/drush
 [debug] Bootstrap further to find pqe [0.11 sec, 8.48 MB]
 [debug] Trying to bootstrap as far as we can [0.11 sec, 8.48 MB]
 [bootstrap] Drush bootstrap phase: bootstrapDrupalRoot() [0.11 sec, 8.48 MB]
 [bootstrap] Change working directory to /home/alec/d8/web [0.11 sec, 8.48 MB]
 [bootstrap] Initialized Drupal 8.7.6 root directory at /home/alec/d8/web [0.11 sec, 8.67 MB]
 [bootstrap] Drush bootstrap phase: bootstrapDrupalSite() [0.12 sec, 8.96 MB]
 [bootstrap] Initialized Drupal site default at sites/default [0.12 sec, 9.19 MB]
 [bootstrap] Drush bootstrap phase: bootstrapDrupalConfiguration() [0.12 sec, 9.19 MB]
 [debug] Add service modifier [0.13 sec, 9.34 MB]
 [bootstrap] Drush bootstrap phase: bootstrapDrupalDatabase() [0.13 sec, 9.76 MB]
 [bootstrap] Successfully connected to the Drupal database. [0.13 sec, 9.76 MB]
 [bootstrap] Drush bootstrap phase: bootstrapDrupalFull() [0.13 sec, 9.76 MB]
 [debug] Start bootstrap of the Drupal Kernel. [0.13 sec, 9.76 MB]
 [debug] Finished bootstrap of the Drupal Kernel. [0.23 sec, 17.65 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\config\ConfigCommands [0.36 sec, 27.79 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\config\ConfigExportCommands [0.36 sec, 27.82 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\config\ConfigImportCommands [0.36 sec, 27.83 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\BatchCommands [0.36 sec, 27.84 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\CliCommands [0.37 sec, 27.84 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\DrupalCommands [0.37 sec, 27.84 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\EntityCommands [0.37 sec, 27.85 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\ImageCommands [0.37 sec, 27.86 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\JsonapiCommands [0.37 sec, 27.87 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\LanguageCommands [0.37 sec, 27.88 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\LocaleCommands [0.37 sec, 27.89 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\MessengerCommands [0.37 sec, 27.9 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\QueueCommands [0.37 sec, 27.9 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\RoleCommands [0.37 sec, 27.91 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\StateCommands [0.37 sec, 27.94 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\TwigCommands [0.38 sec, 27.95 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\UserCommands [0.38 sec, 27.97 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\ViewsCommands [0.38 sec, 28.01 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\core\WatchdogCommands [0.38 sec, 28.04 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\pm\PmCommands [0.38 sec, 28.06 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\pm\ThemeCommands [0.38 sec, 28.07 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\sql\SanitizeCommands [0.38 sec, 28.08 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\sql\SanitizeCommentsCommands [0.39 sec, 28.08 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\sql\SanitizeSessionsCommands [0.39 sec, 28.09 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\sql\SanitizeUserFieldsCommands [0.39 sec, 28.09 MB]
 [debugnotify] Add a commandfile class: Drush\Drupal\Commands\sql\SanitizeUserTableCommands [0.39 sec, 28.09 MB]
 [debugnotify] Add a commandfile class: Drupal\module_missing_message_fixer\Commands\MmmfFixCommand [0.39 sec, 28.1 MB]
 [debugnotify] Add a commandfile class: Drupal\module_missing_message_fixer\Commands\MmmfListCommand [0.39 sec, 28.1 MB]
 [debugnotify] Add a commandfile class: Drupal\webform\Commands\WebformCommands [0.39 sec, 28.11 MB]
 [debugnotify] Add a commandfile class: Drupal\webform_scheduled_email\Commands\WebformScheduledEmailCommands [0.39 sec, 28.19 MB]
 [debugnotify] Add a commandfile class: Drupal\pathauto\Commands\PathautoCommands [0.39 sec, 28.19 MB]
 [debug] Done with bootstrap max in Application::find(): trying to find pqe again. [0.39 sec, 28.21 MB]

In Application.php line 628:
                                                                  
  [Symfony\Component\Console\Exception\CommandNotFoundException]  
  Command "pqe" is not defined.                                   
                                                                  

Exception trace:
  at /home/alec/d8/vendor/symfony/console/Application.php:628
 Symfony\Component\Console\Application->find() at /home/alec/d8/vendor/drush/drush/src/Application.php:235
 Drush\Application->bootstrapAndFind() at /home/alec/d8/vendor/drush/drush/src/Application.php:192
 Drush\Application->find() at /home/alec/d8/vendor/symfony/console/Application.php:235
 Symfony\Component\Console\Application->doRun() at /home/alec/d8/vendor/symfony/console/Application.php:147
 Symfony\Component\Console\Application->run() at /home/alec/d8/vendor/drush/drush/src/Runtime/Runtime.php:118
 Drush\Runtime\Runtime->doRun() at /home/alec/d8/vendor/drush/drush/src/Runtime/Runtime.php:49
 Drush\Runtime\Runtime->run() at /home/alec/d8/vendor/drush/drush/drush.php:72
 require() at /home/alec/d8/vendor/drush/drush/includes/preflight.inc:18
 drush_main() at phar:///usr/local/bin/drush/bin/drush.php:141
 require() at /usr/local/bin/drush:10

Other drush commands work fine in my environment

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States owlick

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States japerry KVUO

    Repurposing this support request into the larger issue. The purge drush commands currently require a sub module to be enabled. This is sub-optimal because composer cannot easily detect the drush commands services from a sub module.

    The PR will move and rewrite the drush commands, while still providing backwards compatibility

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States japerry KVUO
  • Comment over 1 year ago →
    🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    Balu Ertl → made their first commit to this issue’s fork.

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    The steps I followed to simulate a possible scenario of updating the module to its new version:

    1. $ composer require 'drupal/purge:3.4' – assume the latest stable version being installed on a site
    2. $ drush en purge_drush purge_queuer_coretags purge_processor_cron – enable all the sub-modules as the docs of v3.4 prescribes
    3. $ drush pdia – Diagnostics report (maybe with a red line at its top) should appear
    4. $ drush ptyp – an 8-item list should appear
    5. Leave the purge_drush sub-module enabled on the site
    6. $ composer clear-cache
    7. $ composer require "drupal/purge:dev-3078507-refactor-drush-commands" -W – temporarily this represents the future version
    8. $ drush updb – no DB updates were detected for me
    9. $ drush cc, then „0” – empty Drush’ cache
    10. $ drush cr
    11. $ drush pdia – the diagnostics report should appear
    12. $ drush ptyp – an 8-item list should appear

    This way I ensured that the Drush commands were still properly discovered and usable before moving up them from their sub-module.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    570 pass, 10 fail
  • @balu-ertl opened merge request.
  • Comment over 1 year ago →
    🇭🇺Hungary Balu Ertl Budapest 🇪🇺
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    570 pass, 10 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    570 pass, 10 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    570 pass, 10 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    597 pass, 4 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    610 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    610 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    610 pass
  • Comment over 1 year ago →
    System Message
  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States japerry KVUO

    Fixed!

    Note: the drush queues will be automatically enabled if you have drush_purge enabled now. If you don't, you can manually enable the plugins within the purge ui.

  • Comment over 1 year ago →
    🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    On my local instance, Composer automatically updates the required "dev-3.x" version this is how I realized that the plugin class has suddenly disappeared:

    →

    @japerry do you think we should leave behind placeholders for the classes within the /modules/purge_drush/src/Plugin/Purge directory to notify others about the deprecation?

    →

  • Comment over 1 year ago →
    🇺🇸United States japerry KVUO

    This only requires a cache refresh, which was added as a database update to purge.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇦🇺Australia acbramley

    enable_by_default = true was removed from the Drush processor plugin for whatever reason so anyone upgrading to 3.5 will need to run drush p:processor-add drush_purge_queue_work (which gets output when trying to run the queue-work command) and then export configuration.

    This probably should have been included in an update hook in this issue.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024