Migrations not being detected for source plugins with Url data parser

Created on 23 August 2019, over 5 years ago
Updated 16 December 2024, 2 days ago

Hi, thanks for the work on this module!

It works great for CSV migrations, but it seems not to be working with JSON or XML migrations. In buildForm() it uses the $migrationInstance->getSourcePlugin() method and check against classes that are instances of `Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Json` and `Drupal\migrate_plus\Plugin\migrate_plus\data_parser\XML`. Those are the data parser classes, but getSourcePlugin() actually returns the source plugin which is `Drupal\migrate_plus\Plugin\migrate\source\Url`. Therefore the validation fails for JSON and XML files.

Am I overseeing something? If this is truly a bug, an alternative would be to use $migrationInstance->getSourceConfiguration() and check the `data_parser_plugin` key. I can provide a patch if this approach is desired.

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇳🇮Nicaragua dinarcon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024