Remove unused variables - Contrib.social

FILE: ...r/drupal/pareviewsh/pareview_temp/src/Theme/ThemeFieldNegotiator.php -------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------- 194 | WARNING | Unused variable $theme_field_name. 202 | WARNING | Unused variable $applies. -------------------------------------------------------------------------- FILE: ...ewsh/pareview_temp/src/Plugin/Field/FieldWidget/ThemeFieldWidget.php -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------- 35 | WARNING | Unused variable $info. --------------------------------------------------------------------------

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇪🇨Ecuador jwilson3
Patch no longer applied.

❯ wget https://www.drupal.org/files/issues/2019-08-08/3073455-2.patch ❯ git apply 3073455-2.patch error: patch failed: src/Plugin/Field/FieldWidget/ThemeFieldWidget.php:32 error: src/Plugin/Field/FieldWidget/ThemeFieldWidget.php: patch does not apply
Furthermore:

In the case of unused foreach variable $theme_field_name, phpmd no longer reports unused foreach variables https://github.com/phpmd/phpmd/pull/198

In the case of unused variable $info in ThemeFieldWidget.php, that variable no longer exists.

Therefore the remaining code change from the original scope amounts to a single commit to remove the unused $applies.

I also noticed an intelliphense warning of an Undefined variable $page_entity, which I've also fixed here.
Comment about 1 year ago →
System Message

jwilson3 → committed c90a7dcb on 8.x-1.x
Issue #3073455 by jwilson3: Fix undefined variable $page_entity
Comment about 1 year ago →
System Message

jwilson3 → committed 8932c6f8 on 8.x-1.x authored by vuil →
Issue #3073455 by vuil, jwilson3: Remove unused variables
Status changed to Fixed about 1 year ago11:22am 24 August 2023
Comment about 1 year ago →
🇪🇨Ecuador jwilson3
Comment about 1 year ago →
System Message

jwilson3 → committed c62aba60 on 8.x-1.x
Issue #3073455 by vuil, jwilson3: Remove unused variables
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.