No form validation if start date is greater than end date

Marked the following as duplicates

• 🐛 No form validation if start date is greater than end date Closed: duplicate
• 🐛 Alpha widget no error for end date before start date Closed: duplicate
• 🐛 Alpha widget throws exception when end date is before start date Closed: duplicate

The tests from this one are conflicting with the tests added a few days later in #3074571: Alpha widget doesnt adjust time zone properly → . It looks like both the alpha test in this issue and the other issue are based of DateRecurModularOscarTest added a number of months earlier, which is why the merge/diff is a bit whack.

Tests above are red, needs a reroll.

I'd start with the tests committed then copy over tests from this issue or Sierra.

Can we get a MR.

Thanks

MR opened. I can see that the build looks like it will fail with an error that Drupal\date_recur_entity_test\Entity\DrEntityTest does not exist. I can say locally with a feature branch off of 3.2.x that this class does exist and Drupal\date_recur_entity_test\Entity\DrEntityTestBasic does not, which is why I "fixed" this in my MR. Not sure what's going on there.

I figured out what was going on with the missing test entity class and opened a separate issue:

https://www.drupal.org/project/date_recur_modular/issues/3544698 🐛 DrEntityTest renamed in date_recur, tests against 3.2.x-dev fail Active

If anyone has any tips for the best way to temporarily get the dev requirements for this module for development purposes (as specified in require-dev in composer.json, let me know. I'm aware there are PHPCS issues that need fixing, but I don't have the ruleset being used.

@maskedjellybean RE #20 I have been trying to get DDEV contrib to help make this question not a thing, but there is documentation here that is generic enough that should get you over the hump:
https://www.drupal.org/node/1419988 →

I will first try to get it into date_recur 📌 Add DDEV Drupal Contrib for ease-of-maintenance Needs review , then do the same thing here. Please do have a peek at that issue, especially if you are familiar with DDEV already for your local environment.

Thank you @joelpittet. I should’ve been more clear. I can run phpcs but when I run it from the root of this module it tries to use a ruleset that I don’t have. I would have it if I manually composer required all the modules/packages defined in the module’s require-dev section of composer.json and then avoided committing that change to my personal project. I just hoped there was an automated way that didn’t affect my project. Perhaps I’ll work on a tool like that.

Oh what is the ruleset you don't have? You might be able to add it to your composer global if you can pick it out of the require-dev dependencies.