- 🇧🇪Belgium tim-diels Belgium 🇧🇪
I see the benefits for this. For now the Olark configuration is indeed not translatable, so the script is the same for all languages.
Seeing in the Olark documentation there are multiple ways to integrate languages. But allowing to translate the code snippet has more benefits in having customisable options per language.The normal string type is not translatable. So it must change to label or text.
For the change to the text string subtype, I would say it is indeed needed as this could be a long string.Please see the explanation for common string subtypes:
There are some purpose specific subtypes of the simple string type, particularly for UI generation and translatability purposes, such as:
- label: short and translatable string
- text: long and translatable string
As review for the patch, I can say this works as expected.