Negative usage limits and date range validation

Created on 27 June 2019, over 5 years ago
Updated 29 October 2024, 2 months ago

I donโ€™t know whether this issue works as intended but I thinks we need more validations on this fields.

  • Current usage limit can be filled with negative number
  • End date can be set before or same as start date

๐Ÿ› Bug report
Status

Needs review

Version

3.0

Component

Promotions

Created by

๐Ÿ‡ฎ๐Ÿ‡ฉIndonesia tofasuriawan Malang

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

    @tofasuriawan thanks, indeed that should be fixed. Could you turn this into a MR against 3.x maybe? And best would be to add some simple tests.

Production build 0.71.5 2024