"$this" can no longer be used in a plain function or method since PHP 7.1.

As far as I know statically declared methods cannot use $this whether called statically or not in PHP 7/8. So I think we should safely remove the whole condition and just keep the code creating a new instance of PHPVideoToolkit class and calling the getFFmpegInfo(). In the patch #5, the if and else branches are now the same, so it will be better to remove it altogether.

Patch #2 would not work, because we cannot call non-static method statically in modern PHP versions, see: https://www.php.net/manual/en/migration80.incompatible.php .

I am going to commit the updated patch soon.

Thanks all, committed!

Just final note - I have not considered removing the function although it seems not used by any code in the Video module. But it can be probably used for example by other contrib modules, so better to keep it there.

If you need a non-static version that uses $this->getFFmpegInfo(), you could have a non-static version of the function that calls the static one and passes in $toolkit as a param. If $toolkit is null, get it from new PHPVideoToolkit().

Automatically closed - issue fixed for 2 weeks with no activity.