- 🇳🇱Netherlands spokje
I believe the screen resizing isn't necessary anymore.
The normal routine to prove a random failure is fixed is to run the failing patch and the patch with the fix at the same time, whilst the latter has to have ~8000 - 10.000 failure free runs to prove it's credibility.
Since this issue is a bit different, there is no failing test, we can "just" run the patch without the screen resize and see if it has ~8000 - 10.000 failure free runs
So let's do that here.
18:04 17:19 Running18:04 17:19 Running18:04 17:19 Running18:04 17:19 Running17:54 16:38 Running17:48 15:57 Running17:42 15:57 Running17:36 15:57 Running17:24 15:57 Running- 🇳🇱Netherlands spokje
Ok...
5000x seems a bit too much, after we hit around 45 minutes in the test run, things go "wonky".
Let's see what 3000x brings us - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass 20:24 15:57 Running20:24 16:44 Running- last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass 33:20 32:19 Running33:06 32:19 Running33:00 32:19 Running32:54 32:19 Running32:48 32:19 Running- 🇳🇱Netherlands spokje
11 * 3000 = 33.000 runs without a failure.
Good enough for me, here's the actual patch. - last update
over 1 year ago 29,448 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:59am 14 June 2023 - Status changed to RTBC
over 1 year ago 1:48pm 14 June 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I believe the screen resizing isn't necessary anymore.
This issue is to figure out why this line was making the test pass, but something in the meanwhile has made this no longer needed. The patch in #14 looks great. I would love to know why but I think we can commit this as-is.
- last update
over 1 year ago 29,477 pass - last update
over 1 year ago 29,499 pass - last update
over 1 year ago 29,499 pass - last update
over 1 year ago 29,531 pass - last update
over 1 year ago 29,553 pass - last update
over 1 year ago 29,554 pass - last update
over 1 year ago 29,562 pass - last update
over 1 year ago 29,566 pass - last update
over 1 year ago 29,571 pass - last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,805 pass - last update
over 1 year ago 29,811 pass - last update
over 1 year ago 29,814 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,822 pass 11:25 9:20 Running-
longwave →
committed c61764be on 11.x
Issue #3055982 by Spokje, alexpott: Remove resizing window in...
-
longwave →
committed c61764be on 11.x
- Status changed to Fixed
over 1 year ago 1:47pm 22 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.