Why the duplicated group type visibility settings in the Group Operations block?

Created on 4 May 2019, about 6 years ago
Updated 11 June 2025, 16 days ago

I am looking at the Group Operations block and under the Visibility settings see tabs for;

1. Group type (with checkbox Negate the condition)
2. Group types (without the negate option)

They both appear to work and do the same thing. Its a bit confusing.

I am wondering if there is some subtle difference which is not apparent to me, or whether it's a feature/bug which is duplicating functionality provided by Drupal core.

Can someone enlighten me please ?

πŸ› Bug report
Status

Active

Version

2.3

Component

User interface

Created by

πŸ‡¬πŸ‡§United Kingdom mrpauldriver

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States kroh San Antonio, TX

    @mrpauldriver the issues you refer to in #5 have all been fixed.

    As it stands today, the Entity module in core provides Condition panes (singular titles and a negation option) for all entity bundles in /core/lib/Drupal/Core/Entity/Plugin/Condition, and the Group module provides its own Condition pane (plural title, no negation option) in /modules/contrib/group/src/Plugin/Condition for group type selection.

    Apparently the solution that was used for duplicate conditions for Content types was to move the condition code from ctools to core, and hide the old condition.

    So, perhaps Group doesn't need to provide a Condition for group types at all, and can rely on the one provided by core.

  • πŸ‡§πŸ‡ͺBelgium kristiaanvandeneynde Antwerp, Belgium

    Yeah I'd need to look into this but when I added it way back when there was no core-provided alternative. We could compare the one from core to the one from Group and perhaps remove the one in Group. Would need an update hook to convert all blocks to start using the one in core.

Production build 0.71.5 2024