Incompatibility with feeds FeedsProcessor::entityValidate

Created on 25 April 2019, almost 6 years ago
Updated 18 March 2023, about 2 years ago

Commerce feeds is throwing the following error when used with the 2.x version of feeds

Declaration of FeedsCommerceProductProcessor::entityValidate($product) should be compatible with FeedsProcessor::entityValidate($entity, ?FeedsSource $source = NULL)                                  [warning]
FeedsCommerceProductProcessor.inc:11

Feeds has updated the entityValidate function spec and now requires a second argument.

Patch attached to update the function spec.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom aamortimer

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • I think this commit never made it into a release?

  • 🇳🇱Netherlands megachriz

    @tonytheferg
    That's correct, the commit was only added to the dev version. I guess it could be a good idea to create a new release for the D7 version.

    To be honest, I give this project almost zero attention. The only maintenance I really do at the moment for this project is making sure the module keeps working with newer Drupal and Feeds versions.

  • Ah, Yeah, I just applied to code to my installed version because I wasn't sure if I should uninstall the module. I don't use it. It was used on my site when it was built for me before I started developing.

Production build 0.71.5 2024