- 🇭🇺Hungary mxr576 Hungary
FTR, Opened ✨ Add Retry-After header to HTML maintenance mode responses Active as a follow up because a Retry-After header for HTML responses could be useful as well.
The issue is fairly straight forward...
Whenever people need to update D8 instructions are the following:
https://www.drupal.org/docs/8/update/update-core-via-composer →
... Stuff
Site into maintenance.
... Stuff
Site out of maintenance.
In decoupled context there is no correct way to handle the event -
site is in maintenance mode
.
So there will be public clients hitting the website, as well as jsonapi endpoints fetching data.
The issue with the maintenance mode is easily reproducible:
1. Have public read access against jsonapi endpoints.
2. Enable site maintenance mode.
3. You get a non-valid jsonapi response and broken clients. Note that from the headers of the response clients can not distinguish that it's a maintenance mode response or some reverse proxy interrupted the request.
This is preventing safe deploys on systems running jsonapi or other modules used in decoupled context. In production environment when the system is a fully decoupled one, once the site is in maintenance mode - all public clients are down.
JSON:API should add it's own maintenance mode middle-ware before the core's existing one.
RTBC and commit
None.
jsonapi has a new setting to set Retry-After header values when the site is in maintenance mode.
None.
Maintenance mode now triggers an event to allow custom behaviour. JSON:API uses this event to serve a JSON:API response with Retry-After header when the site is in maintenance mode.
Fixed
9.4
Last updated
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
FTR, Opened ✨ Add Retry-After header to HTML maintenance mode responses Active as a follow up because a Retry-After header for HTML responses could be useful as well.