Contrib.social

history_write not called when node displayed in a modal window

Open on Drupal.org →
Created on 17 April 2019, over 5 years ago
Updated 25 July 2023, over 1 year ago

I am trying to build a view that will show the users which nodes are new or updated for them and let them view these nodes in a modal window, so that they do not leave the page. Unfortunately, the new/updated is still shown after opening the page in this way.

How to reproduce?

  1. Build a view showing node titles with a link to open the node and new/updated tag.
  2. On the page rendering this view, click on a link, then reload the page. "new" or "updated" flag will be cleaned.
  3. Now add the class="use-ajax" to a href, to open the node in a modal window instead of opening in the new page.
  4. On the page rendering this view, click on a link, then reload the page. "new" or "updated" flag will not be cleaned.
🐛 Bug report
Status

Closed: works as designed

Version

9.5

Component
History  →

Last updated 4 months ago

No maintainer
Created by

🇦🇹Austria Deno

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇳🇱Netherlands Lendude Amsterdam

    Looking at history_node_view_alter that must mean that $display->getOriginalMode() === 'full' isn't true in that case?

    Not sure it's a bug per se, I think history makes an effort to only mark things read when the full node is viewed to make sure lists and stuff don't mark things read. So I'm not surprised if it doesn't mark it read in some situations where you would hope it would.

  • Status changed to Closed: works as designed over 1 year ago
  • Comment over 1 year ago →
    🇫🇷France andypost

    Yes, that's done intentionally - not every display of entity should mark it skipped

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024