ProductVariation::prepareRow() is complex and brittle and perhaps doing things in the wrong place

Created on 27 March 2019, almost 6 years ago
Updated 3 September 2024, 4 months ago

Problem/Motivation

During development a few bugs have come from \Drupal\bigcommerce\Plugin\migrate\source\ProductVariation::prepareRow(). This code seems brittle and perhaps we're doing things wrong.

Proposed resolution

  • Move all the processing that's done here into a new process plugin. So the source plugin doesn't require other migrations to have already been run.
  • Try and make sure that all assumptions are catered for and clear exceptions are thrown when expectations not met.

Remaining tasks

Discuss

User interface changes

None

API changes

Possible new process plugin

Data model changes

None

Release notes snippet

N/a

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024