Image Caption always shows label of field

Hi,

I had this problem with D9.3.0 and photoswipe 3.1.4.

Updated to photoswipe 3.2.4 and the problem is not solved.

When selecting "Photoswipe image caption" = "Image alt tag" the label of the image alt field is not displayed.

When selecting "Photoswipe image caption" = "field_caption", a custom field I added to the media type, the field's label, "Caption", is displayed together with the field's value (see attached image).

In "Manage display" section of the media type, the label of caption_field is set to hidden, so it should not appear.

Thanks in advance for fixing this and please let me know if you need more information.

@Yanivs thank you very much. So I'll reopen this.

Could you please then add a test which proves the wrong behaviour, so we can clearly fix it for the future? That would be super helpful.
There are many tests existing in the module, which should give you a good starting point.

Could you please create a test to show this issue? The module seems simple but has become quite complex for the many cases including media, responsive images etc. so we need tests to ensure nothing breaks in the future and proof something is broken.

Thanks you :)

3.x is now 4.x! :)

NW as of #31

As soon as someone provides the required tests, we can proceed here. Also someone could check if the issue is resolved in 5.x then we could decide to close this and use 5.x instead.

Please let us know, if the issue still exists in 5.x

Has been fixed in 5.x: 🐛 Photoswipe Caption: Selected source field is printed including the field label (no matter if the label is turned off in the field configuration) Needs work

If anyone needs a backport, feel free to cherry-pick as MR.