Allow users to update their settings regardless of duplicate email addresses in the users table.

I have copied the patch from #5 to MR and added one additional test case to confirm/deny my statement from #5 about MySQL/SQLite.

Seems like the test results are consistent on all PHP/SQL combinations and that the test is failing both with different cased letters and same cased letters. See the complete results here: https://git.drupalcode.org/project/drupal/-/pipelines/145289

So it seems like that my previous statement from #5

This patch will not fix the situation (in MySQL, SQLite),

is not correct. The PHP comparision does not make any difference, because we are comparing the user email address with the email address submitted by the form - and these two should be equal in every case when user is not changing email. I think I was confused and though that we are comparing the duplicate email instead of user email. Therefore I think the patch looks good and it is ready for review.

Adding a tag for the final review.

This looks good.

I thought I'd spotted a tiny problem in the test because the docs for \DrupalTestCase::randomName() say:

  /**
   * Generates a random string containing letters and numbers.
   *
   * The string will always start with a letter. The letters may be upper or
   * lower case.

If that was literally true, the test may not always be doing exactly what we want it to.

However, the first letter will actually always be lowercase:

$str = chr(mt_rand(97, 122));

...so the problem there is slightly misleading documentation, rather than a bug in the new test here.

We could fix the docs in a follow-up, but it's not a top priority.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.