Contrib.social

"Preview image style" and "Crop preview image style" field descriptions are confusing

Open on Drupal.org →
Created on 8 January 2019, over 6 years ago
Updated 16 February 2023, about 2 years ago

As a site builder, I assumed I should use a cropped image style for both "Preview image style" and "Crop preview image style" and I suspect many folks would do the same.

This results in an unexpected output where you crop an image, and then on edit, the already cropped image has the same crop widget appear on top of it. (It works as long as you don't resize the crop, but it looks broken or that you'll end up with a tiny "double cropped" image)

I found the old issue https://www.drupal.org/project/image_widget_crop/issues/2845343 → here which lead me to the understanding of how the fields are to be used.

My proposed resolution: update the descriptions below the fields

BEFORE
Preview image style
The preview image will be shown while editing the content.

Crop preview image style
The preview image will be shown while editing the content.

AFTER
Preview image style
The image with the applied crop. Select an image style that applies the crop action.

Crop preview image style
The source image that the crop widget is applied to. Select an image style that does not apply the crop action.

If this description looks right to the maintainers I can create a patch.

🐛 Bug report
Status

Needs work

Version

2.0

Component

User interface

Created by

🇨🇦Canada afoster

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Comment 10 months ago →
    🇺🇸United States scotwith1t Birmingham, AL

    I don't know if this is the right place for this or not, but it should also be documented somewhere that using an image style that is cropped will almost certainly result in things going wrong. The Crop Preview Image Style should always be something that is ONLY scaled, otherwise you will get unexpected results where the applied crop is not actually represented properly by the widget's preview.

  • Comment 6 months ago →
    🇳🇱Netherlands eelkeblok Netherlands 🇳🇱

    I agree with #5. I think it would be a good idea to add some verification to make sure that the crop preview does not include any crops.

  • Comment 5 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
  • Comment 5 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    And I am still not sure if we have already optimized the documentation in this regard: https://www.drupal.org/project/image_widget_crop/issues/2845343#comment-... →

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024