Missing config schema for block

Created on 31 December 2018, almost 6 years ago
Updated 29 August 2024, 3 months ago

social_media_links_block is mising config schema so I'm attaching a patch including it.

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡΅πŸ‡ͺPeru piggito

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • πŸ‡©πŸ‡ͺGermany tobiasb Berlin

    fyi: The weight should be a integer and show_name a boolean. I fixes this already in the fork.

  • Status changed to Needs work 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States japerry KVUO

    With πŸ› Missing config schema for field, widget and formatter Fixed committed, this likely needs a reroll. Also, would like to see some tests similar to the other issue before it gets committed.

  • πŸ‡·πŸ‡ΊRussia ilya.no

    I've been using patch, made from the MR, via https://git.drupalcode.org/project/social_media_links/-/merge_requests/1..., but after upgrading to D10.3.2 I've got error, as described in https://www.drupal.org/project/social_media_links/issues/3461790 πŸ› Schema error after updating to drupal 10.3 Closed: cannot reproduce .

    I haven't traced the issue, but it seems to be related to the solution with src/Plugin/Config/Schema/Platforms.php, because when I removed corresponding changes and added code from #12 patch, then the issue was gone.

    I'm attaching a bit updated patch with several fixes in order to have ability for deploy.

    I think, that issue's priority should be set to Critical, because currently it's not possible to import configuration.
    In order to reproduce, need to create page manager variant and add "Social Media Links" block.

  • πŸ‡«πŸ‡·France colin.eininger

    I have created new drupal 10.2 and 10.3 instances, installed social_media_links module with the patch from MR!12. Added a block and exported the configuration. Then removed the block and imported the configuration.

    Everything works as expected.

    In order to troubleshoot your problem @ilya.no, can you describe all minimal step to reproduce ? In the other issue you said "Need to create page manager page". Is that the layout builder your refering to ?

  • Assigned to colin.eininger
  • πŸ‡«πŸ‡·France colin.eininger

    Ok, I wasn't on 10.3 during my tests. Tried again and reproducing the error. I'm looking at the issue rn.

  • πŸ‡«πŸ‡·France colin.eininger

    colin.eininger β†’ changed the visibility of the branch 3023172-missing-config-schema to hidden.

  • πŸ‡«πŸ‡·France colin.eininger

    colin.eininger β†’ changed the visibility of the branch 3023172-missing-config-schema to active.

  • Issue was unassigned.
  • Status changed to Needs review 3 months ago
  • πŸ‡«πŸ‡·France colin.eininger

    I fixed the error on drupal 10.3.

    When drupal retrieve a map key, it try to guess which type its parent is and expect the parent to be either a MapDataDefinition or a SequenceDataDefinition.

    We were using the ListDataDefinition which is unexpected. I switched our social_media_links.platforms type to use SequenceDataDefinition (which inherit from ListDataDefinition).

    I tested the patch on drupal 10.2 and 10.3.

Production build 0.71.5 2024