Toolbar overlap content with big pipe enabled

Created on 18 December 2018, over 5 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

With big pipe enabled on profile pages the toolbar overlaps the content.

After loading the page initial the toolbar overlaps the heading.

After clicking on admin in the menu to close the sub menu the same margin as before is used.

After opening the sub menu again the height is correctly set and all the content moves downwards.

Steps to reproduce:

  1. Install a fresh Drupal site with a standard profile.
  2. Login as admin
  3. Click 'Edit profile' on the toolbar
  4. You can see that the toolbar overlaps the body of the page.

With BigPipe enabled this happens as the toolbar links are fetched later by Drupal\user\ToolbarLinkBuilder::renderToolbarLinks

On load the toolbar gets initializied and sets the padding-top of 40px. After that big pipe adds the toolbar, but doesn't invoke ToolbarVisualView.updateToolbarHeight

Proposed resolution

TBD

Maybe an option would be that big pipe introduces a new event when it's finished loading a block so ToolbarVisualView then can update the toolbar height.

Remaining tasks

Fix and test

User interface changes

none

API changes

none

Data model changes

none

Release notes snippet

🐛 Bug report
Status

Needs work

Version

10.1

Component
Toolbar 

Last updated 4 days ago

  • Maintained by
  • 🇫🇷France @nod_
Created by

🇩🇪Germany kfritsche 🇩🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Production build 0.71.5 2024