- π¨π¦Canada awasson
Can the maintainer weigh in on whether this issue is outdated or if it still needs review?
I am maintaining a site that has had this patch applied and I can't update the site via composer because this patch has been applied and composer sees that
drupal/direct_checkout_by_url has modified files:
M src/Controller/CheckoutByUrlController.php
M tests/src/Functional/RedirectTest.phpThanks,
Andrew - π³π΄Norway eiriksm Norway
The maintainer (me) is waiting for feedback from people running this patch. It seems you have been testing this patch then? Myself and the community is generally awaiting for feedback on this, so I am looking forward to hearing your feedback, experience and review π€βοΈ
- π¨π¦Canada awasson
Hi Eirik,
It seems that the patch is effective. I didn't install it but I can attest to it being effective. I'll contact the Dev who patched it and get some more feedback.
Cheers,
Andrew - π³π΄Norway eiriksm Norway
And since we are trying to get this kind of old issue resolved here, maybe @robcarr or @halefx has any feedback, review or experience as well? Let's do it, people! ππ€ (Get the issue resolved that is)
- π¬π§United Kingdom robcarr Perthshire, Scotland
@eiriksm the patch worked well at the time, but - 3 years on - not sure if it still works. I didn't want to RTBC the patch at the time as nobody else had tested it. The site/project I was working on was cancelled and unfortunately I've had little to do with Commerce since.
- last update
about 1 year ago Patch Failed to Apply - π¨π¦Canada awasson
It is still working for me and is necessary.
I see no errors reported in my Recent log messages. I see it passes against PHP 7.2 so I've just queued it for a test against PHP 8.0.
Drupal 9.5.11
Direct Checkout by URL 8.x-1.1Cheers,
Andrew - π¨π¦Canada awasson
Oops. I think the patch will have to be rerolled against the latest dev before running a test.
- Status changed to Needs work
about 1 year ago 5:55pm 26 September 2023 - π³π΄Norway eiriksm Norway
How about a merge request as a re-roll please? π€
- Status changed to Needs review
8 months ago 2:15pm 4 April 2024 - Status changed to Needs work
8 months ago 2:30pm 4 April 2024 - π³π΄Norway eiriksm Norway
Would really appreciate if that could be in a merge request. That's how the tests will be able to run now