Make it possible to choose the order type

Created on 11 December 2018, almost 6 years ago
Updated 4 April 2024, 8 months ago

Currently hardcoded to "default".

Should be a config option and an alter hook.

✨ Feature request
Status

Needs work

Version

1.1

Component

Code

Created by

πŸ‡³πŸ‡΄Norway eiriksm Norway

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡¦Canada awasson

    Can the maintainer weigh in on whether this issue is outdated or if it still needs review?

    I am maintaining a site that has had this patch applied and I can't update the site via composer because this patch has been applied and composer sees that
    drupal/direct_checkout_by_url has modified files:
    M src/Controller/CheckoutByUrlController.php
    M tests/src/Functional/RedirectTest.php

    Thanks,
    Andrew

  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    The maintainer (me) is waiting for feedback from people running this patch. It seems you have been testing this patch then? Myself and the community is generally awaiting for feedback on this, so I am looking forward to hearing your feedback, experience and review πŸ€“βœŒοΈ

  • πŸ‡¨πŸ‡¦Canada awasson

    Hi Eirik,

    It seems that the patch is effective. I didn't install it but I can attest to it being effective. I'll contact the Dev who patched it and get some more feedback.

    Cheers,
    Andrew

  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    And since we are trying to get this kind of old issue resolved here, maybe @robcarr or @halefx has any feedback, review or experience as well? Let's do it, people! πŸ˜œπŸ€“ (Get the issue resolved that is)

  • πŸ‡¬πŸ‡§United Kingdom robcarr Perthshire, Scotland

    @eiriksm the patch worked well at the time, but - 3 years on - not sure if it still works. I didn't want to RTBC the patch at the time as nobody else had tested it. The site/project I was working on was cancelled and unfortunately I've had little to do with Commerce since.

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update about 1 year ago
    Patch Failed to Apply
  • πŸ‡¨πŸ‡¦Canada awasson

    It is still working for me and is necessary.

    I see no errors reported in my Recent log messages. I see it passes against PHP 7.2 so I've just queued it for a test against PHP 8.0.

    Drupal 9.5.11
    Direct Checkout by URL 8.x-1.1

    Cheers,
    Andrew

  • πŸ‡¨πŸ‡¦Canada awasson

    Oops. I think the patch will have to be rerolled against the latest dev before running a test.

  • Status changed to Needs work about 1 year ago
  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    How about a merge request as a re-roll please? πŸ€“

  • Status changed to Needs review 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States mcchuck
  • Status changed to Needs work 8 months ago
  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    Would really appreciate if that could be in a merge request. That's how the tests will be able to run now

Production build 0.71.5 2024