Remove "Variable substitution"

Created on 7 December 2018, over 6 years ago
Updated 20 April 2024, 12 months ago
🐛 Bug report
Status

Closed: cannot reproduce

Version

1.0

Component

Code

Created by

🇮🇹Italy nicola85

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇯🇵Japan ptmkenny

    I am closing this issue because there has been no follow-up in five years.

  • 🇳🇱Netherlands megachriz

    I see now that on the first iteration, $variables is an empty array. So then the removed call $expression = strtr($expression, $variables); does effectively nothing. But later in the loop, $variables can contain something.

    Anyway, it looks like the code should stay - even though what it does is apparently not covered by tests.

Production build 0.71.5 2024