Fix inconsistencies of TextareaWidget and TextareaWithSummaryWidget form elements

Created on 27 November 2018, over 5 years ago
Updated 28 March 2024, 3 months ago

Problem/Motivation

  • Templates of text_format_wrapper print `attributes` to the description what ends in uninterpretable aria attribute.
  • Text summary behavior (text/drupal.text library) uses theme-provided classes for it's operations which may be broken in custom themes.

Proposed resolution

Fix text_format_wrapper by printing attributes to the main wrapper and providing the missing attribute for the description.
Add js classes to the TextareaWithSummaryWidget for the text/drupal.text library (where text/drupal.text is attached).

Remaining tasks

Provide a patch with test.

User interface changes

Nothing.

API changes

None.

Data model changes

Nothing.

Release notes snippet

@Todo

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
TextΒ  β†’

Last updated 9 days ago

Created by

πŸ‡­πŸ‡ΊHungary huzooka Hungary πŸ‡­πŸ‡ΊπŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States dww

    Coming from #2421445-30: Text format wrapper does not honor description_display β†’ . To fix that bug, I wanted to entirely remove some code that lives in the wrong templates, yet it includes a @see comment pointing here. πŸ˜… During self-review (#30.4) I pointed out the brokenness of attributes not being used in the wrapper element. Now that I'm reading the summary here, that's most of what this issue aims to fix. Hopefully this will be smaller and easier to land once we get the description out of the way entirely and leave that to form-element.html.twig itself (when {{ children }}is rendered).

    I won't formally mark this postponed, but it should probably wait until #2421445 lands...

Production build 0.69.0 2024