- Status changed to Needs review
over 1 year ago 2:55pm 22 May 2023 - last update
over 1 year ago 29 pass - last update
over 1 year ago 29 pass - last update
over 1 year ago 8 pass, 8 fail -
podarok β
committed e486d9e6 on 2.0.x authored by
eugene.brit β
Issue #3015323 by ziomizar, eugene.brit, Musa.thomas: IEF does not...
-
podarok β
committed e486d9e6 on 2.0.x authored by
eugene.brit β
- Status changed to Fixed
over 1 year ago 3:10pm 22 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Needs review
12 months ago 10:18pm 9 December 2023 - Status changed to Needs work
12 months ago 10:45pm 9 December 2023 - π©πͺGermany geek-merlin Freiburg, Germany
I still like this a lot. Revisiting this after quite some time, my gut feeling is that this must not re-purpose hook_entity_prepare_form, but invent an IEF version of it. (Anyone with a good reasoning that it is not so, please explain!)
- π©πͺGermany geek-merlin Freiburg, Germany
The related issue confirms that this implementation is wrong and must not be committed.
An IEF version of that hook makes sense though. - πΊπΈUnited States dww
This seems to have caused some major regressions. See π Parent form entity builders run on IEF resulting in fatal errors Active
- π©πͺGermany geek-merlin Freiburg, Germany
#14:
> still like this a lot. Revisiting this after quite some time, my gut feeling is that this must not re-purpose hook_entity_prepare_form, but invent an IEF version of it.Comment #3364996-15: Parent form entity builders run on IEF resulting in fatal errors β of that issue elaboratest that brilliantly.
Updating title accordingly.