The ModeratedNodeListBuilder does not show the correct revisions

Created on 21 November 2018, almost 6 years ago
Updated 18 July 2023, over 1 year ago

Problem/Motivation

In #2902187: Provide a way for users to moderate content β†’ a UI was introduced which allows users to see the content that needs to be moderated. Basically revisions that are not published. And this was done with Views (if the module is enabled) or using the ModeratedNodeListBuilder.

The Views approach works correctly, as it was tested. However, the list builder does not. The problem occurs when a draft is created after a node is already published (revision ahead of the published one). In this case, the draft revision is not listed, and it should.

Proposed resolution

The fix is quite simple: in the ModeratedNodeListBuilder::getEntityRevisionIds() we need to add a latestRevision() clause to the query.

Remaining tasks

  • Write a test for the list builder
  • Fix the query

User interface changes

None

API changes

None

Data model changes

None

πŸ› Bug report
Status

Closed: cannot reproduce

Version

11.0 πŸ”₯

Component
Content moderationΒ  β†’

Last updated about 14 hours ago

  • Maintained by
  • πŸ‡¦πŸ‡ΊAustralia @Sam152
Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Since there hasn't been a follow up going to close for now.

    If still an issue please reopen updating the issue summary with additional steps.

    Thanks everyone!

Production build 0.71.5 2024