Add ability to upload custom patch(es)

Created on 22 October 2018, over 6 years ago

Updated 9 January 2024, over 1 year ago

Problem/Motivation

Using the advanced settings, there is the possibility to apply patches to projects by supplying an URL to the patch. It would be convenient if there would also be a possibility to upload custom .patch files, so you can easily test if the patch applies correctly and if the functionality works as intended.

Proposed resolution

Under the advanced section, add a file upload field that allows to upload .patch files. The uploaded patch files should be applied after the modules are downloaded, but before they are installed.

Remaining tasks

Create patch that adds the ability to upload and apply local patch files
Include error-handling in case the patch could not be applied (e.g. wrong version of module, or incorrect patch file)

User interface changes

Under the 'Advanced options' section, clicking the 'Apply patch' button should also review UI elements required to upload a custom file (likely a file-field with an 'upload' button, perhaps also a text-label that shows if the upload was successful or has failed).

API changes

Probably none(?)

Data model changes

Probably none(?)

✨ Feature request

Status

Closed: won't fix

Version

3.0

Component

Code

Created by

🇳🇱Netherlands Dimiter

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇬🇧United Kingdom rachel_norfolk UK
Whilst it would be very convenient to apply patches from any location, it does mean that anyone, anonymously, can run any php code they want on stm.

That’s quite a risk.

The current restrictions on patch location means that at least we know who made any naughty code and take actions to prevent that.

To be honest, creating an issue on a module and adding a patch to that issue is always a good idea, anyway, as it allows collaborative working.

I’m going to close this (as I have another similar issue)

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024