add an assigned reviewer field; suggest that work on an issue only starts once there is an assigned developer AND reviewer

Created on 12 October 2018, over 6 years ago
Updated 22 April 2025, 4 days ago

Problem/Motivation

Drupal core currently has 45 pages of issues waiting for review, for Drupal 8 alone.

- that's ~ 2250 issues with patches
- by page 18, we get to issues that have not been touched in 6 months. That's ~ 1350 issues.

The patches on these issues are rotting. Some of them might be irrelevant now. Some might need rerolling or updating for changes that have since been committed.

These patches represent WASTED work. That's contributed hours that could have been better spent.

The problem is that there are not enough people who spend time reviewing patches. Reviewing patches is hard, and takes time. It's not your itch, and it's not your own problem you are fixing.

Proposed resolution

My suggestion for reducing this wastage is this:

- change the 'assigned' field on issues to be 'assigned developer'
- add an 'assigned reviewer' field to issues
- suggest, STRONGLY, that work should not be started on issues until both of those fields have been set.

What I am proposing basically is that we instigate a cultural change that instead of the process being:

1. I have found a problem / I have an idea
2. code code code code
3. post a patch
4. walk away and hope someone reviews it, or spend ages trying to find someone to review code that is now rotting by the day

-- which is basically 'sling it over a wall', we do this instead:

1. I have found a problem / I have an idea
2. either try to find another user who is interested to be a reviewer, or wait until someone offers on the issue
3. code code code code
4. post a patch
4. reviewer hopefully honours their commitment to review the patch

Feature request
Status

Active

Component

Idea

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇿New Zealand quietone

    The ideas project is deprecated.

    It has been 8 years and there has been no support for this idea. Given that I think this should be closed.

  • 🇧🇪Belgium borisson_ Mechelen, 🇧🇪

    I think the needs review queue initiative has made this a lot better as well, there are currently 177 issues in needs review for modern Drupal. So I think adding more people to that initiative is a better solution to this problem.

  • 🇬🇧United Kingdom joachim

    It's still really hard to get people to review MRs.

Production build 0.71.5 2024