The text filter must provide support for mailto links that contains another text value than an email address

Created on 1 October 2018, about 6 years ago
Updated 25 November 2023, about 1 year ago

The text filter, used for html text formats, applies obfuscation properly on a plain text email address (mail@example.com) and an email address enclosed in the <a> tag (<a href="mailto:mail@example.com">mail@example.com</a>).

The obfuscation support have to be extended to a text enclosed in the <a> tag (<a href="mailto:mail@example.com">Contact us</a>).

📌 Task
Status

Postponed: needs info

Version

1.0

Component

Code

Created by

🇨🇭Switzerland colorfield Lausanne

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇦🇺Australia nigelcunningham Geelong

    I've just completed a bit of a rewrite, including changes in this area. Please test the 2.0.x dev branch.

    Thanks!

  • 🇩🇪Germany mrshowerman Munich

    I tested the 2.0.x branch and it works nicely.

  • Status changed to RTBC about 1 year ago
  • 🇫🇷France Grimreaper France 🇫🇷

    Hi,

    I applied patch from comment 4 on 2.0.0 version and it fixes the bug.

    Thanks!

  • Status changed to Postponed: needs info about 1 year ago
  • 🇦🇺Australia nigelcunningham Geelong

    Hi @Grimreaper.

    I've just tried applying the patch and am not seeing a case where it still makes any difference - it applies, but doesn't seem to make any difference to the output. Could you help me out with a case where you're still seeing an issue without the patch being applied?

    Thanks!

    Nigel

  • 🇫🇷France Grimreaper France 🇫🇷

    Hi @Nigel Cunningham,

    The following code in the RTE:

    <a href="mailto:example@example.com">write us</a>

    Before patch, will produce:

    <a href="mailto:example@example.com" rel="nofollow">example@example.com</a>

    After patch, will produce:

    <a href="mailto:example@example.com" rel="nofollow">write us</a>

    Hope this help.

    Thanks :)

  • Status changed to Active about 1 year ago
  • Status changed to Postponed: needs info about 1 year ago
  • 🇦🇺Australia nigelcunningham Geelong

    Morning Grimreaper.

    Apologies first for the delay in getting back to this.

    I've just enabled Obfuscate afresh in my module dev install, added the Obfuscate filter to the end of the Basic HTML configuration and put "write us" in the source of a normal node's WYSIWYG, using basic HTML for the format. On the resulting page, the source shows:


    write us

    Could I get you to point out what I'm doing differently? The commit I'm on is fa512f3b (2.0.x branch)

    Thanks!

  • 🇫🇷France Grimreaper France 🇫🇷

    Hi @Nigel Cunningham,

    No problem for the reply delay.

    Since the last comment even with patch the problem still occured randomly so I gave up on using Obfuscate and uninstalled it.

    I was on 2.0.0 version and I also had the "Convert URLs into links" filter enabled.

    If on another project I will have to use Obfuscate and still got the problem, I will give news.

  • 🇦🇺Australia nigelcunningham Geelong

    Thanks!

    I'll try again with the info you provided.

Production build 0.71.5 2024