- π©πͺGermany geek-merlin Freiburg, Germany
Current code makes sense to spread files amongst multiple directories.
Imho it's too complicated wrt the 2-level iterator (use basename instead) and ensureCacheFolderExists (which can be done when writing).It does not yet address the main issue topic, limiting number of files.
- πΊπΈUnited States SocialNicheGuru
could an error_log message be thrown and not an exception.
i have several instances where it is thrown but on refresh the subdirectory is created.
so maybe have it logged and treat it as a cache miss instead. - Status changed to Needs review
over 1 year ago 7:06am 17 May 2023 - last update
over 1 year ago 4 fail - πΊπΈUnited States SocialNicheGuru
Rerolled patch to throw an error not and exception when a directory cannot be created.
I agree with @geek-martin. This should be renamed to "Create multiple subdirectories to improve performance". It is not about limiting files.
The last submitted patch, 10: 3001324-create-multiple-subfolders.patch, failed testing. View results β
- Status changed to Needs work
over 1 year ago 7:17am 17 May 2023 - πΊπΈUnited States SocialNicheGuru
Changed the name to: Create multiple subdirectories to improve performance
since it does not limit the number of cache files.The patches and MR are related to that.
- Status changed to Needs review
over 1 year ago 10:23am 24 June 2023 - last update
over 1 year ago 4 fail - πΊπΈUnited States SocialNicheGuru
rerolled for filecache 1.1
changed throw exception to error_log
Use case:
There seem to be race conditions or "phantom errors" that appear. I do not want the site to crash. Instead log the error. The last submitted patch, 14: 3001324-11-create-multiple-subfolders-log-errors-14.patch, failed testing. View results β