D6 and D7 file migrate source plugins are incompatible with highwater marks

Created on 6 September 2018, almost 7 years ago
Updated 23 May 2025, 16 days ago

Problem/Motivation

Both the Drupal 6 and Drupal 7 file migrate source plugins order their queries. From what I can tell this adds nothing, functionally, to the plugins.

https://api.drupal.org/api/drupal/core%21modules%21file%21src%21Plugin%2...
https://api.drupal.org/api/drupal/core%21modules%21file%21src%21Plugin%2...

A consequence of this is that people cannot use highwater marks successfully with these source plugins unless their high_water_property happens to be "timestamp". Why? Because in order for highwater marks to work, the query must be ordered by the high_water_property.

If you, for instance, specify "fid" for the high_water_property, that won't work because it will simply be appended to the existing order by conditions. Sort will be first by timestamp, then by fid, which will break the highwater marks functionality for your migration.

Proposed resolution

Remove query ordering from the D6 and D7 file migrate source plugins.

Remaining tasks

Patch, tests, review.

πŸ› Bug report
Status

Postponed

Version

11.0 πŸ”₯

Component

migration system

Created by

πŸ‡ΊπŸ‡ΈUnited States chrisolof

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024