- πΊπΈUnited States moshe weitzman Boston, MA
I no longer see MemcacheBackendUnitTest in 8.x version. Did we lose test coverage over the years?
- πΊπΈUnited States japerry KVUO
MemcacheBackendUnitTest was moved/renamed to the MemcacheBackendTest in 2018 by Damian.
https://git.drupalcode.org/project/memcache/-/commit/f30543ba2d991e5fd06...
There isn't any issue associated with it, but I'm guessing it had to do with the bootstrapping of memcache. Interestingly its still referencing GenericCacheBackendUnitTestBase -- so I'm not sure why it was moved out of a unit test.
- π³πΏNew Zealand ericgsmith
The existing failures have come up in a couple of issues, π Transaction support for cache (tags) invalidation Needs review and π Add optional DDEV dev environment Needs review
Debugging I found that a lot of times where the get is called the cache item created and last bin deleted timestamps were the same - so the data is returned from memcache but when timeIsGreaterThanBinDeletionTime is called in the memcache backed, the timestamps are equal so it returns false and doesn't return anything from the cache backend service.
I tried in https://git.drupalcode.org/project/memcache/-/merge_requests/22/diffs?co... to reduce the tolerance to 0 and that greatly reduced the number of test failures, but not all of them - so I suspect there are additional issues, or the tolerance of 0 is still somehow flakey.
If think it makes sense to tackle the existing failures in this issue first so just cross posting here.
-
japerry β
committed ce852139 on 8.x-2.x authored by
ericgsmith β
Issue #2996055: Test coverage
-
japerry β
committed ce852139 on 8.x-2.x authored by
ericgsmith β
- Status changed to Needs work
6 months ago 10:18pm 21 May 2024 - πΊπΈUnited States japerry KVUO
Thanks ericgsmith for the MR! I've been playing around with the test failures as well to no avail. Going to merge in your MR for now but keep this issue open and NW due to the remaining failures...
-
japerry β
committed 3b967741 on 8.x-2.x
Issue #2996055 by japerry, ericgsmith, Wim Leers: Test coverage
-
japerry β
committed 3b967741 on 8.x-2.x
- Status changed to Fixed
4 months ago 5:23pm 11 July 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
japerry β credited Wim Leers β .
- πΊπΈUnited States japerry KVUO
Tests are passing and reliably both locally and on gitlabci! Thanks Wim for the rubber ducking with me!
Automatically closed - issue fixed for 2 weeks with no activity.