Allow multiple terms and duplicated names

Re-rolled for RC1.

Thanks for moving this forward. I would have committed it for RC1, but there's still no test coverage at all (hence the "Needs tests" tag). That really needs to happen before I can be confident it does what we want, and that we're not going to break it in the future. 😅

Luckily, there's already tests/src/Functional/ArgumentValidatorTest.php for someone to extend...

Thanks again,
-Derek

New patch including tests for this feature.

Thank you!

The last submitted patch, 17: 2979312-17-test-only.patch, failed testing. View results →

I've tested this out locally with the latest patch -17 and it appears to be doing exactly what it says on the tin... great work!

I found two problems in patch #17.

1st Problem

The module currently allows the use of terms with white space (e.g. “Dummy Example”), after testing the patch I can no longer get the expected behavior.
It seems to me that the problem is in the regex that is used to split the terms:
$exploded_arguments = preg_split('/[,+ ]/', $argument);
This contains a blank space, thus giving rise to this unexpected behavior.

2nd Problem

The contextual filter "Has taxonomy term ID" has an option to "Allow multiple values", which is deactivated by default, however the patch ignores the option and always accepts multiple values.

The attached patch provides a proposed solution for these two problems.

I just had to remove the latest patch from my site because it caused a previously working view to return no results.