I see several tests were updated in the merge request built off of #28. Here's a patch that includes my changes in #37 and those test updates.
I'm unsure what tests changed, but I re-ran tests for MR#28 and it also failed the same tests as #39. Something must've changed in this module through another commit to break these tests.
- First commit to issue fork.
- Status changed to Needs review
11 months ago 3:09am 11 January 2024 - πΊπΈUnited States dcam
I turned #39 into an MR against the 3.x branch. I had to reroll it in the process. I can't help but think that it was all the unrelated blank line additions that caused the problem. Afterward I fixed the newer test failures.
I'm removing the Needs Tests tag. I assume it was necessary at one time because of the addition of the setting. But now it's just a visual change and the existing tests are having to account for the dropdowns. So I think we're good here. If it does need additional testing, then please let me know what specifically you would like to have tested.
- Status changed to RTBC
11 months ago 9:54am 11 January 2024 - π¬π§United Kingdom jonathanshaw Stroud, UK
I think this is ready at last, and a real improvement.
- Status changed to Needs work
10 months ago 11:31pm 28 January 2024 - π©πͺGermany geek-merlin Freiburg, Germany
Reviewed the code and found an issue.
This is a UI change, so needs a ChangeRecord. - Status changed to RTBC
about 1 month ago 10:01am 23 October 2024 - π¨π¦Canada mandclu
I added a change record β , so moving this back to RTBC.
- π¬π§United Kingdom jonathanshaw Stroud, UK
The change record mentions a widget setting. But the latest MR seems to follow #26 and do this automatically without a setting.
Also there's a code fix requested on the MR in #48.