- 🇺🇸United States luke.leber Pennsylvania
Hello all! I think that this change needs a post-update hook with this pseudo-logic:
for every role on the site if the role has the "administer site configuration" permission add the "administer social_media" to the role save the role end if end for
Without this update hook in place, site administrators may find that their editors no longer have access to the functionality they need to perform their duties. With this, setting back to NW.
Thanks!
- Assigned to Chandreshgiri Gauswami
- Status changed to Active
over 1 year ago 2:02pm 9 May 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:46pm 12 May 2023 - last update
over 1 year ago Patch Failed to Apply - 🇺🇸United States luke.leber Pennsylvania
Hey, thanks for the re-roll. Recent commits added the post update file, so make sure 2.0.x is up to date in the re-roll. Things have been moving somewhat quickly.
This can probably be hardened / simplified a bit by using
$role->grantPermission('administer social_media');
Instead of the procedural equivalent. (Just in-case
user_role_grant_permissions
is deprecated in the 10.x/11.x release cycle). - Assigned to Chandreshgiri Gauswami
- Status changed to Active
over 1 year ago 6:20am 15 May 2023 - 🇮🇳India Chandreshgiri Gauswami
Hi @Luke.Leber
Updating patch with suggested changes. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:49am 16 May 2023 - last update
over 1 year ago 1 pass