D7 EFQ Finder to D8 Entity finder

Went back to patch from #29 and fixed the deprecated method issues and it worked with D9.5

Hello all.

Firstly I wanted to say thank you to everybody who has contributed to this issue. It has been a very long slog and so many people have contributed.

I have taken a quick look and made some tidy ups.

Please consider this a work in progress, and I have removed a bunch of stuff to get the tests going. I am not trying to discourage those ideas, I just wanted to share progress before I put them down.

Namely
- removed entity repository. Querying by uuid still works with entity query, I couldn't see why we needed to introduce another service for this field
- used a Kernel test. We can maybe revisit this, but this is a complicate plugin - the current state of the unit test was not complete, and being unfamiliar with the work so far it was easier for me to look at this with a kernel test.

Now a warning - I only looked at this via tests - I have not even looked at the UI or how that renders.

Adding patch now but it is still needs a few improvements. I will try tidy up the issue summary and remaining steps soon.

1. +++ b/src/Plugin/Tamper/EntityFinder.php
   @@ -0,0 +1,280 @@
   +    // $form_state->setCached(FALSE);
   

   I need to revisit the form side - this should either be there or removed, advice welcomed on what this is for and what other plugins are doing.

2. +++ b/src/Plugin/Tamper/EntityFinder.php
   @@ -0,0 +1,280 @@
   +      '#empty_option' => t('-- Select --'),
   

   Should be $this->t

3. +++ b/src/Plugin/Tamper/EntityFinder.php
   @@ -0,0 +1,280 @@
   +  protected function getfields($entity_type, $bundle) {
   

   Case needs to match where this is called

Oops - wrong namespace in test - ignore 54

Ok cool, green test! A few coding standard violations in the plugin and test noted in ci

Thank you for the work you're doing to finally take tamper out of alpha stability! 🙏🏻 Unfortunately I'm not skilled enough to help directly with code but I'm with you emotionally and can test when ready 💪🏻

Does not work with current DEV branch.

I'm hiding all the patches. Work should continue in the MR.

And I wonder if this plugin should support config entity types? I limited it to content entity types for now, because I accidentally selected a config entity type and it resulted into the error that the entity type did not have base field definitions.

FYI I've created a similar tamper module: https://github.com/hepabolu/feeds_tamper_lookup_entity

This one works for me, but since this is my first Drupal module feel free to correct and improve or assimilate into your version.