- 🇷🇺Russia shra
Updated version of facets_pretty_paths-2974822-5.patch for v1.6.0 (D10)
- Assigned to andreasderijcke
- Issue was unassigned.
- 🇧🇪Belgium andreasderijcke Antwerpen / Gent
I don't understand how patch from #10 could work at all on D10, since it still uses a service that is removed in D10.
Trying applying the same principles to current codebase led me to the following issue.The setRouteParameter
$url->setRouteParameter('facets_query', trim($pretty_paths_string, '/')); $url->setRouteParameter('facets_query', $pretty_paths_string);
(see https://git.drupalcode.org/issue/facets_pretty_paths-2974822/-/blob/2974...)
causing the URL to be routed (again), which in turn causes different url generator functions bringing us back to square one.
Currently seeing no way to create an unrouted url object with routeparameters, which makes sense, without diving deep into core. - 🇧🇪Belgium jorisclaes
It will not work we need the path_alias.manager service.
I changed the patch so it uses this service.
Thanks for the issue without this I would have searched for many hours more. - First commit to issue fork.
- Merge request !15Issue:2974822: Facets should check `path.alias_manager` when generating their URL. → (Open) created by ankitv18
- last update
5 months ago 7 pass - Status changed to Needs review
5 months ago 4:47pm 15 June 2024 - last update
5 months ago Patch Failed to Apply - last update
5 months ago Patch Failed to Apply - last update
5 months ago 7 pass - last update
5 months ago Patch Failed to Apply - last update
5 months ago Patch Failed to Apply