-
tim-diels โ
committed 123eb725 on 2.0.x authored by
alemadlei โ
Issue #2971208 by alemadlei, rfulcher, tim-diels, nicola85: Config...
-
tim-diels โ
committed 123eb725 on 2.0.x authored by
alemadlei โ
- Status changed to Fixed
over 1 year ago 11:42am 5 April 2023 - ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
Thanks for the work done, I committed this.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 6:45am 27 May 2023 - ๐ซ๐ทFrance andrimont
Hello all,
I still encounter this issue on
Drupal 10.0.9
PHP 8.1.18
MariaDB 10.5.19-MariaDB-0+deb11u2
DAL domain_access_logo 2.0.2The configuration cannot be imported because it failed validation for the following reasons: Configuration <strong>domain_logo.settings</strong> depends on the <strong>domain_logo</strong> extension that will not be installed after import.
I had this issue already before upgrading DAL to the 2.0.2 version.
I do not think that I should use the patch.Any idea of a fix as it is very troublesome ?
- ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
You still have the old config. There is no automatic update path provided. We could maybe do this. But the manual update path would be to rename the domain_logo.settings to domain_access_logo.settings in your config folder and rename the module dependency in the file from domain_logo to domain_access_logo.
Typing this from the beach so is untested but should work.
- ๐ซ๐ทFrance andrimont
Thank you Tim,
but I see no file as the domain_logo.settings :$ grep -rl "domain_logo.settings" . ./modules/contrib/domain_access_logo/src/Form/DomainAccessLogoSettingsForm.php
And
$ nano ./modules/contrib/domain_access_logo/src/Form/DomainAccessLogoSettingsForm.php
shows :*/ public function getFormId() { return 'domain_logo_settings'; } /**
- ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
I mean the configuration from your website. It is stored in the database but is also exported and imported when you use CI/CD to deploy your website.
So not the module config itself which it only used at install of the module and should be good already.
- ๐ซ๐ทFrance andrimont
Fantastic Tim !
Thank you, I found indeed both a domain_access_logo.settings and a domain_logo.settings in the table config of the database.
Now I can process the Import Configuration. I can work on the sites now. Merci. - ๐ซ๐ทFrance andrimont
One thing :
Should I change in
./modules/contrib/domain_access_logo/src/Form/DomainAccessLogoSettingsForm.php
shows :This
public function getFormId() { return 'domain_logo_settings'; }
to
public function getFormId() { return 'domain_access_logo_settings'; }
?
- ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
That should be changed yes. But we need to test nothing breaks and also document the change as this will change form alter hooks. You can suggest the change in a new issue.
- ๐ซ๐ทFrance andrimont
Tim :
That should be changed yes. But we need to test nothing breaks and also document the change as this will change form alter hooks. You can suggest the change in a new issue.
I am teasing it and will come back w/ result.
- ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
It is not tied to the config name but more to allow to form_alter on this specified ID. So it wonโt break normally. Only thing is that it could break sites having a form alter on that ID.