Content Moderation incompatible with Form Mode

Created on 2 May 2018, over 6 years ago

Updated 1 September 2024, 4 months ago

If I add content moderation to an entity that has a form mode enabled, clear cache will show the following error:
Notice: Undefined index: type in Drupal\content_moderation\Routing\ContentModerationRouteSubscriber->setLatestRevisionFlag() (line 74 of core/modules/content_moderation/src/Routing/ContentModerationRouteSubscriber.php).

The function setLatestRevisionFlag() in Drupal\content_moderation\Routing\ContentModerationRouteSubscriber assumes that the default entity form will always have the entity type in$parameter['type'].
However the form mode of an entity has the entity type in $parameter['targetEntityType'] instead.

More specifically, if I replace

if ($parameter['type'] === 'entity:' . $entity_type && !isset($parameter['load_latest_revision'])) {
  $parameter['load_latest_revision'] = TRUE;
 }

with

if (isset($parameter['type']) && $parameter['type'] === 'entity:' . $entity_type && !isset($parameter['load_latest_revision'])) {
  $parameter['load_latest_revision'] = TRUE;
}
elseif (isset($parameter['targetEntityType']) && $parameter['targetEntityType'] === $entity_type) {
  $parameter['type'] = 'entity:' . $entity_type;
  $parameter['load_latest_revision'] = TRUE;
}

apparently all will work fine, but I'm not sure if this is a robust solution.

🐛 Bug report

Status

Closed: outdated

Version

11.0 🔥

Component

Content moderation →

Last updated 24 days ago

Maintained by
🇦🇺Australia @Sam152

Created by

🇺🇸United States helioha Philadelphia, PA

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Bug Smash Initiative

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Closed: outdated 4 months ago6:10am 1 September 2024
Comment 4 months ago →
🇳🇿New Zealand quietone
There has been no activity here for 5 years except to ask, 2 years ago, for confirmation that this problem still exists. Git blame shows that this may have been fixed in #3032548: ContentModerationRouteSubscriber assumes all parameters in an entity form route contain a 'type' key → , which has a change similar to what is in the latest patch here.

Therefore, closing. If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue → (starting from "Install Drupal core").

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024