Contrib.social

Filter empty values from the JavaScript settings

Open on Drupal.org →
Created on 13 April 2018, about 7 years ago
Updated 5 June 2025, 2 days ago

Problem/Motivation

I think we should not be sending empty settings in the Drupal settings. Apart from needless bytes that are transferred over the wire this can lead to subtle bugs. One concrete thing that we hit was that the two-line column header in https://fullcalendar.io/releases/fullcalendar-scheduler/1.9.4/demos/scal... when you click on the "year" view does not work when slotLabelFormat is set to an empty string.

Proposed resolution

Filter empty values in Fullcalendar::process().

📌 Task
Status

Active

Version

3.1

Component

Code

Created by

🇩🇪Germany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 2 days ago →
    🇺🇸United States dcam

    This needs to be triaged by a current maintainer to see if it's something they still want to do. But it sounds reasonable, so I decided to not close it as part of my outdated issue audit. I'm setting the status back to active since I'm assuming that the existing patch will not apply.

  • Comment about 21 hours ago →
    🇨🇦Canada mandclu

    The current version of this module actually goes a step further by keeping track of the defaults for the FullCalendar library, and only passing over settings that are different from the default.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024