Inbound path processing is done twice when validating an URL path

Created on 26 January 2018, almost 7 years ago
Updated 30 January 2023, almost 2 years ago

As discovered in #2802403: Combination of language negotiation and path aliasing can cause a corrupted route cache, 404s β†’ it happens in \Drupal\Core\Path\PathValidator::getPathAttributes() and then again later in \Drupal\Core\Routing\RouteProvider::getRouteCollectionForRequest().

I guess this was refactored at some point without removing the now unnecessary call.

This might be a very small (likely not measurable for most cases) performance improvement and it means less complexity/dependency in PathValidator.

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
RoutingΒ  β†’

Last updated 3 days ago

Created by

πŸ‡¨πŸ‡­Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024