- last update
over 1 year ago 6 pass, 1 fail - 🇺🇸United States tr Cascadia
Deleting votes was added in #3155268: Deleting votes → . In theory I think that resolves this issue?
I re-rolled the patch against the current HEAD. There are only two small things in this patch:
- Calls the parent access control function inside checkAccess(). I think this is a good addition.
- Changes
- if (!($entity instanceof VoteInterface)) { + if ($entity instanceof VoteInterface) {This was mentioned in #2, but I don't understand why. I believe the point of the original conditional is that we're in hook_entity_delete(), which is fired any time any entity is deleted, including vote entities. But what we're trying to do here is to delete any votes on the entity that's being deleted. If it's an actual VoteInterface entity being deleted, we don't have to do anything because you can't vote on a vote.
What I would like to hear from the community is, is this still a problem in the current version of the votingapi module? And does applying this patch change anything?
- last update
over 1 year ago 6 pass, 1 fail The last submitted patch, 11: 2934825-11.patch, failed testing. View results →
- last update
over 1 year ago 10 pass - 🇺🇸United States tr Cascadia
The test failure is caused by this:
- if (!($entity instanceof VoteInterface)) { + if ($entity instanceof VoteInterface) {Here's a new patch without that. As I said above, I think this is wrong anyway.
- last update
over 1 year ago 10 pass - Status changed to Closed: duplicate
over 1 year ago 4:04pm 31 July 2023 - 🇺🇸United States tr Cascadia
Actually, at this point, the proposed changes are being better handled by 📌 Unable to see any voting data when creating a View based on the Vote entity. RTBC , which also contains test cases.
If you are still seeing this problem in the most recent version of Voting API, please try the patch in that other issue and provide feedback there.