Translate confirmation message and submit button

Created on 20 December 2017, over 6 years ago
Updated 19 March 2024, 3 months ago

The confirmation message and the submit button of the subscribe block is not translateable.

πŸ› Bug report
Status

Needs review

Version

1.0

Component

User interface

Created by

πŸ‡¨πŸ‡­Switzerland ytsurk Switzerland

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States xenophyle

    It looks like the changes from the latest patch exist in the current 2.x dev branch. Does anything else need to be done to close this issue?

  • πŸ‡³πŸ‡±Netherlands MegaChriz

    I see that indeed everything in #17 is addressed.

    I do however see in the code base that there is more usage of literal strings where I think that translated strings should be used. You could search in the code base for:

    • '#title' => '
    • '#title' => "

    Note: on '#description' I did not find anything that should be changed.

    Would it be good to address '#title' strings translations here, or is that out of scope?

  • πŸ‡ΊπŸ‡ΈUnited States xenophyle

    @MegaChriz Might as well make translatable strings a new issue.

Production build 0.69.0 2024