Contrib.social

Trying to get checkout steps of an order outside of checkout pages throws an error.

Open on Drupal.org →
Created on 15 December 2017, over 7 years ago
Updated 16 December 2024, 4 months ago

Trying to get checkout steps of an order outside of checkout pages throws an error. Starting with an order

    /** @var \Drupal\commerce_order\Entity\OrderInterface $order */

and calling

    $container = \Drupal::getContainer();
   
    /** @var Drupal\commerce_checkout\CheckoutOrderManagerInterface $order_manager */
    $order_manager = $container->get('commerce_checkout.checkout_order_manager');

    /** @var \Drupal\commerce_checkout\Entity\CheckoutFlowInterface $checkout_flow */
    $checkout_flow = $order_manager->getCheckoutFlow($order);

    /** @var \Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowInterface $checkout_flow_plugin */
    $checkout_flow_plugin = $checkout_flow->getPlugin();
    
    /** @var array $steps */
    $steps = $checkout_flow_plugin->getVisibleSteps();

the expected behavior is to get an array of the checkout steps of the $order we started with. However, this is not the case. The following happens:

  • If we are in a page with a commerce_order parameter the steps of that order are return
  • Else an error " Call to a member function on null" is thrown in the isVisible() method of the first checkout pane.
🐛 Bug report
Status

Needs review

Version

2.0

Component

Checkout

Created by

🇬🇷Greece s.messaris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • @megachriz opened merge request.
  • Comment 4 months ago →
    🇳🇱Netherlands megachriz

    This is still an issue. You cannot rely on routing when requesting the available checkout steps outside the checkout process.

    Use case: display the checkout steps on the /cart page. Multiple carts can exist on this page, so there is no order in the route.

  • Comment about 1 month ago →
    🇮🇱Israel jsacksick

    I actually encountered this as well recently while setting up a straight redirection to checkout on add to cart, while skipping the intermediate /checkout route which doesn't need an order parameter, I believe that is the right and only possible fix.... So, let's see if the tests are passing now, just re-ran the pipeline.

  • Comment about 1 month ago →
    🇮🇱Israel jsacksick

    hm... tests are failing but I'm not sure the failures are related.

  • Comment 11 days ago →
    🇮🇱Israel jsacksick

    OK hadn't realized the MR was opened against 2.x, will open another one against 3.0.x.

  • @jsacksick opened merge request.
  • Comment 10 days ago →
    System Message
    • jsacksick → committed c2283a9b on 3.0.x 
      Issue #2931044 by megachriz, istavros, jsacksick, goz: Trying to get...
  • Comment 10 days ago →
    🇮🇱Israel jsacksick

    Merged! 🎉

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024