Add option to show a button after N pages.

Created on 4 December 2017, over 6 years ago
Updated 10 July 2023, 12 months ago

VIS currently only support automatic scrolling OR manual scrolling by pressing a button. My client has a use case where the scrolling should start automatically, but switch to manual after N pages. The attached patch implements this.

✨ Feature request
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡³πŸ‡±Netherlands legolasbo Middelburg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Is this still an issue with 2.0.x? If yes, please update the version and set the status active again with clear steps or (best) with a test showing what's broken.

    2.0.x is the active development branch.

    If nobody replies, we should assume this is fixed and close this issue outdated.

    Thanks!

  • Status changed to RTBC about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States jrb Raleigh-Durham Area, NC, USA

    Yes, this is still an issue.

    The patch in #19 still applies correctly to the 2.0 branch and adds the requested feature. The comment in #14 describes how to test this, and the patch does include a test.

    We've been using this patch in production for 3+ years.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Thanks @jrb - then I fully agree and hope for an active maintainer to take a look!

    Or would you like to apply as Co-Maintainer here perhaps? (I did the same...)

  • Status changed to Needs work 12 months ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Could this fix please be provided as MR?

Production build 0.69.0 2024