- π©πͺGermany Anybody Porta Westfalica
This issue is still very relevant and should be merged into the 7.x-1.x version. I'll prepare a MR.
- π©πͺGermany Anybody Porta Westfalica
Patch from #1 as MR. Changes are fine and this is still important, as described in the issue summary. Setting priority to Major for the performance reasons.
RTBC!
- Status changed to RTBC
over 1 year ago 10:10am 23 March 2023 - @anybody opened merge request.
- @anybody opened merge request.
- First commit to issue fork.
- @fathershawn opened merge request.
- Status changed to Needs review
over 1 year ago 3:26pm 23 March 2023 - πΊπΈUnited States fathershawn New York
Sufficient changes were recently merged that a local rebase was required. This change looks pretty straightforward to me but please re-check.
- Status changed to RTBC
over 1 year ago 3:28pm 23 March 2023 - π©πͺGermany Anybody Porta Westfalica
Thank you, I was also just on the way for the rebase.
Changes are fine. The "new" array() => [] syntax might be dangerous for super old PHP versions, you decide. I'm fine with that. - Status changed to Needs work
over 1 year ago 3:41pm 23 March 2023 - π©πͺGermany Anybody Porta Westfalica
To be 100% safe, I'll change the syntax to the old one and merge it then, ok?
- πΊπΈUnited States fathershawn New York
Sounds good - my ide clearly just switched it - I had it set to php 7.1
- Status changed to Needs review
over 1 year ago 3:47pm 23 March 2023 - πΊπΈUnited States fathershawn New York
This looks good on a code level. Has anyone verified this change locally?
-
Anybody β
committed 3ac9aa1e on 7.x-1.x authored by
FatherShawn β
Issue #2925281 by Anybody, FatherShawn, labboy0276: Ensure snippets to...
-
Anybody β
committed 3ac9aa1e on 7.x-1.x authored by
FatherShawn β
- Status changed to Fixed
over 1 year ago 3:53pm 23 March 2023 - π©πͺGermany Anybody Porta Westfalica
Merged! Going to tag a release now.
Thank you!
Automatically closed - issue fixed for 2 weeks with no activity.