- ๐ฌ๐งUnited Kingdom daniel.j
daniel.j โ made their first commit to this issueโs fork.
- ๐ฌ๐งUnited Kingdom daniel.j
I've created a fork and branch for this work and pushed changes inline with what jochim suggested.
Currently, I've only added to the docs of 'service_collector' tags in the 'commerce_order' module. I plan to continue to add this documentation in this style to the other modules and declared services.
Please let me know if this change is no longer desired / if a different approach would be better.
- ๐ฌ๐งUnited Kingdom daniel.j
I've added this line of documentation to each of the other services in the commerce core and sub-module services in the '2914933-document-service-tags-service-interfaces' branch, but not made a MR.
It would be great if this could be reviewed. Is this change still desired? Should it be done in a different way? Thanks!
- ๐ฎ๐ฑIsrael jsacksick
@daniel.j: Not sure where your changes can be reviewed? This is the repo to use for the documentation: https://github.com/centarro/commerce-docs.
- @danielj opened merge request.
- ๐ฌ๐งUnited Kingdom daniel.j
@jsacksick Apologies if I've misunderstood, I mean the addition to of the class docs rather than the commerce documentation.
I've openned a MR for review (https://git.drupalcode.org/project/commerce/-/merge_requests/357), however the composer step of the pipeline is failing.
- ๐ฎ๐ฑIsrael jsacksick
Because your MR needs to be against the 3.0.x branch, not 8.x-2.x.
- ๐ฌ๐งUnited Kingdom daniel.j
daniel.j โ changed the visibility of the branch 3.0.x to hidden.
- @danielj opened merge request.
- ๐ฌ๐งUnited Kingdom daniel.j
Thanks! Now a new merge request targeting 3.0.x, hopfully this looks better.
-
jsacksick โ
committed d0b22b49 on 3.0.x authored by
daniel.j โ
Issue #2914933: document service tags for service interfaces
-
jsacksick โ
committed d0b22b49 on 3.0.x authored by
daniel.j โ
Automatically closed - issue fixed for 2 weeks with no activity.