add support for delete multiple form and route

Thanks for this. Probably worth mentioning that it won't work until you run the database update script AND add the "bulk update" field to the commerce_licenses view. At least that was my experience.

Hmm. When I delete a license using "delete" under "operations links," it also deletes the role granted by the license.

When I delete this license using this new "bulk update" operation, it doesn't delete the role.

Did I miss a step or is there a bug?

Thanks for the feedback.

Yes, db updates needs to be run to register the delete action. Once this is done, the bulk update field can then be added in the view manually.

The installed view has been updated (not in the patch...you'll need to latest dev), but that only applies when you are installing the module. A little unsafe to update the view, as a site might have added many customizations to it.

That said, you can run a partial config import using brush, and point it at the module's config/install directory to replace the module configs, if you are okay with losing any changes. (Or, if you didn't make any changes in the first place.)

Run drush cim --partial --source=modules/contrib/commerce_license/config/install to do so. (You could also copy that view config to a new directory and point source there, if you only wanted to replace that config.

IRT the delete not revoking the grant on the bulk operations delete, great catch!

The revoke was implemented in the $license->delete() method, which is invoked by the default delete form. But, the multiple delete form invokes $storage->delete($license), so $license->delete() is bypassed.

I've moved the revocation to an Event Subscriber, which is invoked on either delete method. (This has been committed to the dev branch, in case you were just grabbing the patch on this issue.) If you pull latest dev, this issue should be resolved.

I'd like to test this but I can't because I'm getting this error on most pages of the site. Any idea what's going on? Seems fine if I go back to beta2.

The website encountered an unexpected error. Please try again later.
ArgumentCountError: Too few arguments to function Drupal\commerce_license\LicenseAvailabilityCheckerExistingRights::__construct(), 2 passed in /home/xxx/domains/xxx.xxx.xxx/public_html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 3 expected in Drupal\commerce_license\LicenseAvailabilityCheckerExistingRights->__construct() (line 69 of modules/contrib/commerce_license/src/LicenseAvailabilityCheckerExistingRights.php).
Drupal\commerce_license\LicenseAvailabilityCheckerExistingRights->__construct() (Line: 259)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 434)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 273)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 434)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 237)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 434)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 273)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 37)
Drupal\commerce_order\OrderStorage::createInstance() (Line: 269)
Drupal\Core\Entity\EntityTypeManager->createHandlerInstance() (Line: 258)
Drupal\Core\Entity\EntityTypeManager->getHandler() (Line: 201)
Drupal\webprofiler\Entity\EntityManagerWrapper->getHandler() (Line: 51)
Drupal\webprofiler\Entity\EntityManagerWrapper->getStorage() (Line: 69)
Drupal\commerce_cart\CartProvider->__construct() (Line: 259)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 84)
Drupal\commerce_cart\Plugin\Block\CartBlock::create() (Line: 21)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance() (Line: 76)
Drupal\Component\Plugin\PluginManagerBase->createInstance() (Line: 62)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->initializePlugin() (Line: 57)
Drupal\block\BlockPluginCollection->initializePlugin() (Line: 80)
Drupal\Component\Plugin\LazyPluginCollection->get() (Line: 45)
Drupal\block\BlockPluginCollection->get() (Line: 83)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->setConfiguration() (Line: 99)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->addInstanceId() (Line: 55)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->__construct() (Line: 34)
Drupal\block\BlockPluginCollection->__construct() (Line: 156)
Drupal\block\Entity\Block->getPluginCollection() (Line: 145)
Drupal\block\Entity\Block->getPlugin() (Line: 118)
Drupal\block\BlockAccessControlHandler->checkAccess() (Line: 105)
Drupal\Core\Entity\EntityAccessControlHandler->access() (Line: 314)
Drupal\Core\Entity\EntityBase->access() (Line: 63)
Drupal\block\BlockRepository->getVisibleBlocksPerRegion() (Line: 137)
Drupal\block\Plugin\DisplayVariant\BlockPageVariant->build() (Line: 274)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare() (Line: 132)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
call_user_func() (Line: 110)
Drupal\webprofiler\EventDispatcher\TraceableEventDispatcher->dispatch() (Line: 174)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 38)
Drupal\webprofiler\StackMiddleware\WebprofilerMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 713)
Drupal\Core\DrupalKernel->handle() (Line: 19)

That class did have an additional argument added from another issue. The service definition in commerce_license.services.yml was also updated to provide that additional argument.

A cache rebuild should resolve that issue. drush cr

Oh, duh. Sorry. Yes, the role is now removed with the new dev. Thanks again.

Automatically closed - issue fixed for 2 weeks with no activity.