- πΊπΈUnited States smustgrave
Wonder if still an issue on 8.x-2.x? Checked token_custom and see last commit was 2022 so still relatively active.
- πΊπΈUnited States smustgrave
Checking core entity_id is an int there too.
- Status changed to Needs work
5 months ago 10:41am 28 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
So the quick fix here is to only support entity types where the ID field is an integer. Token custom uses a string ID - which is rare but not unsupported - see https://git.drupalcode.org/project/token_custom/-/blob/8.x-1.x/src/Entit...
So the premise of the fix is correct.
My concern on the fix is what happens when the lock table is very large. I think what we need to do is to create a temporary table that's a copy of the current table. And then make the changes to the schema, and then copy the data in from the other table, and then then drop the table. These should be separate update functions so that they can be batched nicely by the update system.